diff options
| author | Gustavo A. R. Silva | 2018-02-07 17:17:29 +0100 |
|---|---|---|
| committer | David S. Miller | 2018-02-08 21:05:16 +0100 |
| commit | 583133b35ecaea84590e92e2732d1a472747ca7d (patch) | |
| tree | 2f9ec72915048e04e8cc6ee0bfa3e423b3025635 | |
| parent | rtnetlink: require unique netns identifier (diff) | |
| download | kernel-qcow2-linux-583133b35ecaea84590e92e2732d1a472747ca7d.tar.gz kernel-qcow2-linux-583133b35ecaea84590e92e2732d1a472747ca7d.tar.xz kernel-qcow2-linux-583133b35ecaea84590e92e2732d1a472747ca7d.zip | |
atm: he: use 64-bit arithmetic instead of 32-bit
Add suffix ULL to constants 272, 204, 136 and 68 in order to give the
compiler complete information about the proper arithmetic to use.
Notice that these constants are used in contexts that expect
expressions of type unsigned long long (64 bits, unsigned).
The following expressions are currently being evaluated using 32-bit
arithmetic:
272 * mult
204 * mult
136 * mult
68 * mult
Addresses-Coverity-ID: 201058
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/atm/he.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/atm/he.c b/drivers/atm/he.c index e58538c29377..29f102dcfec4 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -738,13 +738,13 @@ static int he_init_cs_block_rcm(struct he_dev *he_dev) #else /* this is pretty, but avoids _divdu3 and is mostly correct */ mult = he_dev->atm_dev->link_rate / ATM_OC3_PCR; - if (rate_cps > (272 * mult)) + if (rate_cps > (272ULL * mult)) buf = 4; - else if (rate_cps > (204 * mult)) + else if (rate_cps > (204ULL * mult)) buf = 3; - else if (rate_cps > (136 * mult)) + else if (rate_cps > (136ULL * mult)) buf = 2; - else if (rate_cps > (68 * mult)) + else if (rate_cps > (68ULL * mult)) buf = 1; else buf = 0; |