diff options
| author | Markus Elfring | 2017-01-08 22:10:40 +0100 |
|---|---|---|
| committer | Ulf Hansson | 2017-02-13 13:20:11 +0100 |
| commit | 63928d4789ebb3f7d35d9261089b3bcc98ae0632 (patch) | |
| tree | 5acb8abf5669b3e2abfe88770d7e56ad4b025531 | |
| parent | mmc: mmc_test: Use kcalloc() in mmc_test_alloc_mem() (diff) | |
| download | kernel-qcow2-linux-63928d4789ebb3f7d35d9261089b3bcc98ae0632.tar.gz kernel-qcow2-linux-63928d4789ebb3f7d35d9261089b3bcc98ae0632.tar.xz kernel-qcow2-linux-63928d4789ebb3f7d35d9261089b3bcc98ae0632.zip | |
mmc: core: Use kmalloc_array() in mmc_alloc_sg()
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data structure by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/mmc/core/queue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index a6496d8027bc..b1986622c60e 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -152,7 +152,7 @@ static struct scatterlist *mmc_alloc_sg(int sg_len, int *err) { struct scatterlist *sg; - sg = kmalloc(sizeof(struct scatterlist)*sg_len, GFP_KERNEL); + sg = kmalloc_array(sg_len, sizeof(*sg), GFP_KERNEL); if (!sg) *err = -ENOMEM; else { |