diff options
| author | Jayamohan Kallickal | 2013-09-29 00:35:40 +0200 |
|---|---|---|
| committer | James Bottomley | 2013-10-25 10:58:04 +0200 |
| commit | 6c83185a72e5a00a927c324e72f7341590a30f2b (patch) | |
| tree | e86b8f2fc7a612995623cd4367720e2052ab82ca | |
| parent | [SCSI] be2iscsi: Fix the MCCQ count leakage (diff) | |
| download | kernel-qcow2-linux-6c83185a72e5a00a927c324e72f7341590a30f2b.tar.gz kernel-qcow2-linux-6c83185a72e5a00a927c324e72f7341590a30f2b.tar.xz kernel-qcow2-linux-6c83185a72e5a00a927c324e72f7341590a30f2b.zip | |
[SCSI] be2iscsi: Fix repeated issue of MAC ADDR get IOCTL
Storing MAC ADDR of each function in it's priv structure to
avoid issuing MAC_ADDR get IOCTL. Based on a flag set/unset
it's decided if MAC_ADDR is stored in priv structure or IOCTL
needs to be issued.
Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/be2iscsi/be_iscsi.c | 3 | ||||
| -rw-r--r-- | drivers/scsi/be2iscsi/be_main.c | 1 | ||||
| -rw-r--r-- | drivers/scsi/be2iscsi/be_main.h | 1 |
3 files changed, 4 insertions, 1 deletions
diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c index ef36be003f67..2496ea7dab78 100644 --- a/drivers/scsi/be2iscsi/be_iscsi.c +++ b/drivers/scsi/be2iscsi/be_iscsi.c @@ -840,7 +840,7 @@ int beiscsi_get_macaddr(char *buf, struct beiscsi_hba *phba) struct be_cmd_get_nic_conf_resp resp; int rc; - if (strlen(phba->mac_address)) + if (phba->mac_addr_set) return sysfs_format_mac(buf, phba->mac_address, ETH_ALEN); memset(&resp, 0, sizeof(resp)); @@ -848,6 +848,7 @@ int beiscsi_get_macaddr(char *buf, struct beiscsi_hba *phba) if (rc) return rc; + phba->mac_addr_set = true; memcpy(phba->mac_address, resp.mac_address, ETH_ALEN); return sysfs_format_mac(buf, phba->mac_address, ETH_ALEN); } diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 0abed0a954eb..5ba575f0051b 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -4948,6 +4948,7 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev, beiscsi_hba_attrs_init(phba); phba->fw_timeout = false; + phba->mac_addr_set = false; switch (pcidev->device) { diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index 3e452578a8a9..5165515652bf 100644 --- a/drivers/scsi/be2iscsi/be_main.h +++ b/drivers/scsi/be2iscsi/be_main.h @@ -348,6 +348,7 @@ struct beiscsi_hba { bool ue_detected; struct delayed_work beiscsi_hw_check_task; + bool mac_addr_set; u8 mac_address[ETH_ALEN]; char fw_ver_str[BEISCSI_VER_STRLEN]; char wq_name[20]; |