summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Mackerras2018-02-13 05:45:21 +0100
committerPaul Mackerras2018-02-13 05:45:21 +0100
commit6df3877fc962c2bb3d0438633dfd24a185af6838 (patch)
treeefa1b6112180182901a903945327ad636d5ab439
parentKVM: PPC: Fix compile error that occurs when CONFIG_ALTIVEC=n (diff)
downloadkernel-qcow2-linux-6df3877fc962c2bb3d0438633dfd24a185af6838.tar.gz
kernel-qcow2-linux-6df3877fc962c2bb3d0438633dfd24a185af6838.tar.xz
kernel-qcow2-linux-6df3877fc962c2bb3d0438633dfd24a185af6838.zip
KVM: PPC: Book3S: Fix compile error that occurs with some gcc versions
Some versions of gcc generate a warning that the variable "emulated" may be used uninitialized in function kvmppc_handle_load128_by2x64(). It would be used uninitialized if kvmppc_handle_load128_by2x64 was ever called with vcpu->arch.mmio_vmx_copy_nums == 0, but neither of the callers ever do that, so there is no actual bug. When gcc generates a warning, it causes the build to fail because arch/powerpc is compiled with -Werror. This silences the warning by initializing "emulated" to EMULATE_DONE. Fixes: 09f984961c13 ("KVM: PPC: Book3S: Add MMIO emulation for VMX instructions") Reported-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
-rw-r--r--arch/powerpc/kvm/powerpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
index 0083142c2f84..52c205373986 100644
--- a/arch/powerpc/kvm/powerpc.c
+++ b/arch/powerpc/kvm/powerpc.c
@@ -1345,7 +1345,7 @@ static int kvmppc_emulate_mmio_vsx_loadstore(struct kvm_vcpu *vcpu,
int kvmppc_handle_load128_by2x64(struct kvm_run *run, struct kvm_vcpu *vcpu,
unsigned int rt, int is_default_endian)
{
- enum emulation_result emulated;
+ enum emulation_result emulated = EMULATE_DONE;
while (vcpu->arch.mmio_vmx_copy_nums) {
emulated = __kvmppc_handle_load(run, vcpu, rt, 8,