summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLothar Waßmann2013-08-14 11:43:59 +0200
committerGreg Kroah-Hartman2013-08-14 21:34:16 +0200
commit769d92c411c3479835d2428edfd167c41d80c5f0 (patch)
tree8e5c16848f110eb34b4304bb554a8d057fa7d6ee
parentusb: chipidea: improve kconfig 2.0 (diff)
downloadkernel-qcow2-linux-769d92c411c3479835d2428edfd167c41d80c5f0.tar.gz
kernel-qcow2-linux-769d92c411c3479835d2428edfd167c41d80c5f0.tar.xz
kernel-qcow2-linux-769d92c411c3479835d2428edfd167c41d80c5f0.zip
usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()
This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> Acked-by: Peter Chen <peter.chen@freescale.com> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/chipidea/ci_hdrc_imx.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index a9a3bcf99dbf..005ad5f11b69 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -208,10 +208,8 @@ static int ci_hdrc_imx_remove(struct platform_device *pdev)
if (data->reg_vbus)
regulator_disable(data->reg_vbus);
- if (data->phy) {
+ if (data->phy)
usb_phy_shutdown(data->phy);
- module_put(data->phy->dev->driver->owner);
- }
clk_disable_unprepare(data->clk);