diff options
| author | Bart Van Assche | 2018-06-22 23:53:03 +0200 |
|---|---|---|
| committer | Martin K. Petersen | 2018-07-02 22:44:32 +0200 |
| commit | 799d44d0fab60a96a0f13cdb13c9cc94ce06765e (patch) | |
| tree | 18eac1a8bcf6bd0ee68361a9028eabced91c9068 | |
| parent | scsi: target: Remove second argument from fabric_make_tpg() (diff) | |
| download | kernel-qcow2-linux-799d44d0fab60a96a0f13cdb13c9cc94ce06765e.tar.gz kernel-qcow2-linux-799d44d0fab60a96a0f13cdb13c9cc94ce06765e.tar.xz kernel-qcow2-linux-799d44d0fab60a96a0f13cdb13c9cc94ce06765e.zip | |
scsi: target/tcm_loop: Avoid that static checkers warn about dead code
The code under the "release:" label can only be reached after se_cmd has
been set to a non-NULL value. Hence remove the if (se_cmd) test. Keep the
else-part since calling transport_generic_free_cmd() is not necessary for a
command that has not been submitted to the core.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 4d3895d5ea43 ("target/tcm_loop: Merge struct tcm_loop_cmd and struct tcm_loop_tmr")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/target/loopback/tcm_loop.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 4c8a97711291..b2e7ff50ff61 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -239,10 +239,7 @@ out: return ret; release: - if (se_cmd) - transport_generic_free_cmd(se_cmd, 0); - else - kmem_cache_free(tcm_loop_cmd_cache, tl_cmd); + kmem_cache_free(tcm_loop_cmd_cache, tl_cmd); goto out; } |