diff options
| author | Ricardo Ribalda Delgado | 2014-08-27 14:57:57 +0200 |
|---|---|---|
| committer | Bjorn Helgaas | 2014-09-22 20:55:58 +0200 |
| commit | 89ec3dcf17fd3fa009ecf8faaba36828dd6bc416 (patch) | |
| tree | 26eb8b09180f5cc64963f3bd50ba4be13a67de34 | |
| parent | PCI: Enable CRS Software Visibility for root port if it is supported (diff) | |
| download | kernel-qcow2-linux-89ec3dcf17fd3fa009ecf8faaba36828dd6bc416.tar.gz kernel-qcow2-linux-89ec3dcf17fd3fa009ecf8faaba36828dd6bc416.tar.xz kernel-qcow2-linux-89ec3dcf17fd3fa009ecf8faaba36828dd6bc416.zip | |
PCI: Generate uppercase hex for modalias interface class
Some implementations of modprobe fail to load the driver for a PCI device
automatically because the "interface" part of the modalias from the kernel
is lowercase, and the modalias from file2alias is uppercase.
The "interface" is the low-order byte of the Class Code, defined in PCI
r3.0, Appendix D. Most interface types defined in the spec do not use
alpha characters, so they won't be affected. For example, 00h, 01h, 10h,
20h, etc. are unaffected.
Print the "interface" byte of the Class Code in uppercase hex, as we
already do for the Vendor ID, Device ID, Class, etc.
[bhelgaas: changelog]
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: stable@vger.kernel.org
| -rw-r--r-- | drivers/pci/pci-sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 9ff0a901ecf7..76ef7914c9aa 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -177,7 +177,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, { struct pci_dev *pci_dev = to_pci_dev(dev); - return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n", + return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02X\n", pci_dev->vendor, pci_dev->device, pci_dev->subsystem_vendor, pci_dev->subsystem_device, (u8)(pci_dev->class >> 16), (u8)(pci_dev->class >> 8), |