diff options
| author | Chris Wilson | 2010-07-24 00:18:51 +0200 |
|---|---|---|
| committer | Eric Anholt | 2010-08-02 04:56:29 +0200 |
| commit | 8dc1775dce10d5e47d2805665804fddf39ea3a90 (patch) | |
| tree | c8929cedb667faacd988eb22312dbe7c72728c0a | |
| parent | drm/i915: Repeat unbinding during free if interrupted (v6) (diff) | |
| download | kernel-qcow2-linux-8dc1775dce10d5e47d2805665804fddf39ea3a90.tar.gz kernel-qcow2-linux-8dc1775dce10d5e47d2805665804fddf39ea3a90.tar.xz kernel-qcow2-linux-8dc1775dce10d5e47d2805665804fddf39ea3a90.zip | |
drm/i915: Attempt to uncouple object after catastrophic failure in unbind
If we fail to flush outstanding GPU writes but return the memory to the
system, we risk corrupting memory should the GPU recovery and complete
those writes. On the other hand, if we bail early and free the object
then we have a definite use-after-free and real memory corruption.
Choose the lesser of two evils, since in order to recover from the hung
GPU we need to completely reset it, those pending writes should
never happen.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Eric Anholt <eric@anholt.net>
| -rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index f45f385c84cd..eeb768818136 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1967,11 +1967,12 @@ i915_gem_object_unbind(struct drm_gem_object *obj) * before we unbind. */ ret = i915_gem_object_set_to_cpu_domain(obj, 1); - if (ret) { - if (ret != -ERESTARTSYS) - DRM_ERROR("set_domain failed: %d\n", ret); + if (ret == -ERESTARTSYS) return ret; - } + /* Continue on if we fail due to EIO, the GPU is hung so we + * should be safe and we need to cleanup or else we might + * cause memory corruption through use-after-free. + */ BUG_ON(obj_priv->active); @@ -2007,7 +2008,7 @@ i915_gem_object_unbind(struct drm_gem_object *obj) trace_i915_gem_object_unbind(obj); - return 0; + return ret; } static struct drm_gem_object * |