summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLi Jun2017-04-14 13:12:07 +0200
committerFelipe Balbi2017-06-13 12:21:08 +0200
commit8e55d30322c6a0ef746c256a1beda9c73ecb27a6 (patch)
tree8aab4548f160577b3300fdddf9376889ef53c91d
parentusb: gadget: udc: renesas_usb3: add support for dedicated DMAC (diff)
downloadkernel-qcow2-linux-8e55d30322c6a0ef746c256a1beda9c73ecb27a6.tar.gz
kernel-qcow2-linux-8e55d30322c6a0ef746c256a1beda9c73ecb27a6.tar.xz
kernel-qcow2-linux-8e55d30322c6a0ef746c256a1beda9c73ecb27a6.zip
usb: gadget: mass_storage: set msg_registered after msg registered
If there is no UDC available, the msg register will fail and this flag will not be set, but the driver is already added into pending driver list, then the module removal modprobe -r can not remove the driver from the pending list. Signed-off-by: Li Jun <jun.li@nxp.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
-rw-r--r--drivers/usb/gadget/legacy/mass_storage.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/usb/gadget/legacy/mass_storage.c b/drivers/usb/gadget/legacy/mass_storage.c
index 125974f32f50..e99ab57ee3e5 100644
--- a/drivers/usb/gadget/legacy/mass_storage.c
+++ b/drivers/usb/gadget/legacy/mass_storage.c
@@ -210,7 +210,6 @@ static int msg_bind(struct usb_composite_dev *cdev)
usb_composite_overwrite_options(cdev, &coverwrite);
dev_info(&cdev->gadget->dev,
DRIVER_DESC ", version: " DRIVER_VERSION "\n");
- set_bit(0, &msg_registered);
return 0;
fail_otg_desc:
@@ -257,7 +256,12 @@ MODULE_LICENSE("GPL");
static int __init msg_init(void)
{
- return usb_composite_probe(&msg_driver);
+ int ret;
+
+ ret = usb_composite_probe(&msg_driver);
+ set_bit(0, &msg_registered);
+
+ return ret;
}
module_init(msg_init);