summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohan Hedberg2015-02-19 16:38:07 +0100
committerMarcel Holtmann2015-02-19 17:05:09 +0100
commita2cb01de1cb1db05b946e0132aeecbb514c57024 (patch)
tree36331b7ac61ec2a46ff80038ed69cf8339bef999
parentBluetooth: Remove bogus check for pending mgmt Set HS command (diff)
downloadkernel-qcow2-linux-a2cb01de1cb1db05b946e0132aeecbb514c57024.tar.gz
kernel-qcow2-linux-a2cb01de1cb1db05b946e0132aeecbb514c57024.tar.xz
kernel-qcow2-linux-a2cb01de1cb1db05b946e0132aeecbb514c57024.zip
Bluetooth: Fix checking for pending Set SSP in Set HS handler
Changing the HS setting requires that SSP is enabled, however so far the code only checked for the SSP flag but not a potentially ongoing Set SSP operation. This patch adds a check for a pending Set SSP command in the Set HS handler, and returns a 'busy' error if one is found. Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
-rw-r--r--net/bluetooth/mgmt.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index cc67d19a7cb8..3a1b537c9aa6 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2175,6 +2175,12 @@ static int set_hs(struct sock *sk, struct hci_dev *hdev, void *data, u16 len)
hci_dev_lock(hdev);
+ if (mgmt_pending_find(MGMT_OP_SET_SSP, hdev)) {
+ err = cmd_status(sk, hdev->id, MGMT_OP_SET_HS,
+ MGMT_STATUS_BUSY);
+ goto unlock;
+ }
+
if (cp->val) {
changed = !test_and_set_bit(HCI_HS_ENABLED, &hdev->dev_flags);
} else {