summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Vetter2013-11-04 08:13:45 +0100
committerDaniel Vetter2013-11-15 20:22:34 +0100
commitb2ea8ef559b4d94190009f3651b5b3ab7c05afd3 (patch)
tree2ad059b8c9a98d05702258ab1e46386d2ac9499f
parenti915: Use 120MHz LVDS SSC clock for gen5/gen6/gen7 (diff)
downloadkernel-qcow2-linux-b2ea8ef559b4d94190009f3651b5b3ab7c05afd3.tar.gz
kernel-qcow2-linux-b2ea8ef559b4d94190009f3651b5b3ab7c05afd3.tar.xz
kernel-qcow2-linux-b2ea8ef559b4d94190009f3651b5b3ab7c05afd3.zip
drm/i915: flush cursors harder
Apparently they need the same treatment as primary planes. This fixes modesetting failures because of stuck cursors (!) on Thomas' i830M machine. I've figured while at it I'll also roll it out for the ivb 3 pipe version of this function. I didn't do this for i845/i865 since Bspec says the update mechanism works differently, and there's some additional rules about what can be updated in which order. Tested-by: Thomas Richter <thor@math.tu-berlin.de> Cc: stable@vger.kernel.org Cc: Thomas Richter <thor@math.tu-berlin.de> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/i915/intel_display.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 3cddd508d110..c9882e816af8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7184,7 +7184,9 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 base)
intel_crtc->cursor_visible = visible;
}
/* and commit changes on next vblank */
+ POSTING_READ(CURCNTR(pipe));
I915_WRITE(CURBASE(pipe), base);
+ POSTING_READ(CURBASE(pipe));
}
static void ivb_update_cursor(struct drm_crtc *crtc, u32 base)
@@ -7213,7 +7215,9 @@ static void ivb_update_cursor(struct drm_crtc *crtc, u32 base)
intel_crtc->cursor_visible = visible;
}
/* and commit changes on next vblank */
+ POSTING_READ(CURCNTR_IVB(pipe));
I915_WRITE(CURBASE_IVB(pipe), base);
+ POSTING_READ(CURBASE_IVB(pipe));
}
/* If no-part of the cursor is visible on the framebuffer, then the GPU may hang... */