summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Meyer2011-11-17 14:05:35 +0100
committerDavid S. Miller2011-11-21 21:02:36 +0100
commitb8ffdbd05f8692cdadccd04464271e48b1e8d439 (patch)
tree25d9fbcb355ed76c6485a33f85bd64d8fa457991
parentRxRPC: Use kmemdup rather than duplicating its implementation (diff)
downloadkernel-qcow2-linux-b8ffdbd05f8692cdadccd04464271e48b1e8d439.tar.gz
kernel-qcow2-linux-b8ffdbd05f8692cdadccd04464271e48b1e8d439.tar.xz
kernel-qcow2-linux-b8ffdbd05f8692cdadccd04464271e48b1e8d439.zip
gianfar: Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/freescale/gianfar_ethtool.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
index 1ea0eb9ee643..5890f4b0c0da 100644
--- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
+++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
@@ -1410,10 +1410,9 @@ static int gfar_optimize_filer_masks(struct filer_table *tab)
/* We need a copy of the filer table because
* we want to change its order */
- temp_table = kmalloc(sizeof(*temp_table), GFP_KERNEL);
+ temp_table = kmemdup(tab, sizeof(*temp_table), GFP_KERNEL);
if (temp_table == NULL)
return -ENOMEM;
- memcpy(temp_table, tab, sizeof(*temp_table));
mask_table = kcalloc(MAX_FILER_CACHE_IDX / 2 + 1,
sizeof(struct gfar_mask_entry), GFP_KERNEL);