summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Shevchenko2014-11-03 18:29:23 +0100
committerLee Jones2014-11-25 17:18:52 +0100
commitbde3e706a63d5c258b3e4f5e327bcf032fb1adfe (patch)
tree6d6f7c4eba4065f08de84b7f3463d80930ab716b
parentmfd: wm8350-core: Fix probable mask then right shift defect (diff)
downloadkernel-qcow2-linux-bde3e706a63d5c258b3e4f5e327bcf032fb1adfe.tar.gz
kernel-qcow2-linux-bde3e706a63d5c258b3e4f5e327bcf032fb1adfe.tar.xz
kernel-qcow2-linux-bde3e706a63d5c258b3e4f5e327bcf032fb1adfe.zip
mfd: lpc_sch: Don't call mfd_remove_devices()
MFD core already cares about failing registration. It will remove successfully registered devices in case of error. Thus, no need to repeatedly call mfd_remove_devices(). Fixes: 5829e9b64e65 (mfd: lpc_sch: Accomodate partial population of the MFD devices) Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r--drivers/mfd/lpc_sch.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/mfd/lpc_sch.c b/drivers/mfd/lpc_sch.c
index c980da479a35..5c38df35a84d 100644
--- a/drivers/mfd/lpc_sch.c
+++ b/drivers/mfd/lpc_sch.c
@@ -193,11 +193,7 @@ static int lpc_sch_probe(struct pci_dev *dev, const struct pci_device_id *id)
return -ENODEV;
}
- ret = mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
- if (ret)
- mfd_remove_devices(&dev->dev);
-
- return ret;
+ return mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL);
}
static void lpc_sch_remove(struct pci_dev *dev)