summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRussell King2009-10-25 23:36:10 +0100
committerRussell King2009-10-25 23:44:30 +0100
commitc06e004c72aa0d1acbc239fb995aa3d823543a8a (patch)
tree62d438159176d4f0090144073297fc093907ba81
parentARM: integrator: allow Integrator to be built with highmem (diff)
downloadkernel-qcow2-linux-c06e004c72aa0d1acbc239fb995aa3d823543a8a.tar.gz
kernel-qcow2-linux-c06e004c72aa0d1acbc239fb995aa3d823543a8a.tar.xz
kernel-qcow2-linux-c06e004c72aa0d1acbc239fb995aa3d823543a8a.zip
ARM: Use GFP_DMA only for masks _less_ than 32-bit
We were using GFP_DMA for masks other than 0xffffffff, which is wrong when some masks are initialized to 0xffffffffffffffff. This caused such masks to obtain memory from the precious DMA pool. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r--arch/arm/mm/dma-mapping.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index b30925fcbcdc..b9590a7085ca 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -205,7 +205,7 @@ __dma_alloc(struct device *dev, size_t size, dma_addr_t *handle, gfp_t gfp,
order = get_order(size);
- if (mask != 0xffffffff)
+ if (mask < 0xffffffffULL)
gfp |= GFP_DMA;
page = alloc_pages(gfp, order);
@@ -289,7 +289,7 @@ __dma_alloc(struct device *dev, size_t size, dma_addr_t *handle, gfp_t gfp,
if (!mask)
goto error;
- if (mask != 0xffffffff)
+ if (mask < 0xffffffffULL)
gfp |= GFP_DMA;
virt = kmalloc(size, gfp);
if (!virt)