summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Chard2017-05-10 11:20:59 +0200
committerGreg Kroah-Hartman2017-05-15 11:48:44 +0200
commitc21376631d6325590e53ac8720312d2b02494103 (patch)
treeb5017684383cf2fb88b8f2e17cbd00c5d862a823
parentstaging: typec: Fix sparse warnings about incorrect types (diff)
downloadkernel-qcow2-linux-c21376631d6325590e53ac8720312d2b02494103.tar.gz
kernel-qcow2-linux-c21376631d6325590e53ac8720312d2b02494103.tar.xz
kernel-qcow2-linux-c21376631d6325590e53ac8720312d2b02494103.zip
staging: ccree: remove extraneous spin_unlock_bh() in error handler
An early error handler in send_request() tries to release a spinlock, but the lock isn't acquired until the loop below it is entered. Signed-off-by: Ian Chard <ian@chard.org> Acked-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/ccree/ssi_request_mgr.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
index 522bd62c102e..8611adf3bb2e 100644
--- a/drivers/staging/ccree/ssi_request_mgr.c
+++ b/drivers/staging/ccree/ssi_request_mgr.c
@@ -376,7 +376,6 @@ int send_request(
rc = ssi_power_mgr_runtime_get(&drvdata->plat_dev->dev);
if (rc != 0) {
SSI_LOG_ERR("ssi_power_mgr_runtime_get returned %x\n",rc);
- spin_unlock_bh(&req_mgr_h->hw_lock);
return rc;
}
#endif