summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRick Farrington2017-03-17 19:23:08 +0100
committerDavid S. Miller2017-03-22 01:42:38 +0100
commitc5b71e633da381c299990341ec88694bd00ecad1 (patch)
treef86ffe8379f4b531b81231c44eedc05ed57ad8dc
parentliquidio: remove duplicate code (diff)
downloadkernel-qcow2-linux-c5b71e633da381c299990341ec88694bd00ecad1.tar.gz
kernel-qcow2-linux-c5b71e633da381c299990341ec88694bd00ecad1.tar.xz
kernel-qcow2-linux-c5b71e633da381c299990341ec88694bd00ecad1.zip
liquidio: add debug error messages to report command timeout
Add timeout error message in lio_process_ordered_list(). Add host failure status in existing error message in if_cfg_callback(). Signed-off-by: Rick Farrington <ricardo.farrington@cavium.com> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/cavium/liquidio/lio_main.c4
-rw-r--r--drivers/net/ethernet/cavium/liquidio/response_manager.c2
2 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index b2d6478ffbd9..afa173de1042 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -2225,8 +2225,8 @@ static void if_cfg_callback(struct octeon_device *oct,
oct = lio_get_device(ctx->octeon_id);
if (resp->status)
- dev_err(&oct->pci_dev->dev, "nic if cfg instruction failed. Status: %llx\n",
- CVM_CAST64(resp->status));
+ dev_err(&oct->pci_dev->dev, "nic if cfg instruction failed. Status: 0x%llx (0x%08x)\n",
+ CVM_CAST64(resp->status), status);
WRITE_ONCE(ctx->cond, 1);
snprintf(oct->fw_info.liquidio_firmware_version, 32, "%s",
diff --git a/drivers/net/ethernet/cavium/liquidio/response_manager.c b/drivers/net/ethernet/cavium/liquidio/response_manager.c
index 1d987d7cd7bd..945633339723 100644
--- a/drivers/net/ethernet/cavium/liquidio/response_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/response_manager.c
@@ -107,6 +107,8 @@ int lio_process_ordered_list(struct octeon_device *octeon_dev,
}
} else if (force_quit || (sc->timeout &&
time_after(jiffies, (unsigned long)sc->timeout))) {
+ dev_err(&octeon_dev->pci_dev->dev, "%s: cmd failed, timeout (%ld, %ld)\n",
+ __func__, (long)jiffies, (long)sc->timeout);
status = OCTEON_REQUEST_TIMEOUT;
}