summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSachin Kamat2012-11-19 10:20:30 +0100
committerInki Dae2012-11-22 09:55:17 +0100
commitc69d5276704e1a9c771de57c0a2e7b69ea3ea578 (patch)
tree1d5903d35a8805f10fc7b25040b6e46c620a4b7a
parentdrm/exynos: Make exynos4/5_fimd_driver_data static (diff)
downloadkernel-qcow2-linux-c69d5276704e1a9c771de57c0a2e7b69ea3ea578.tar.gz
kernel-qcow2-linux-c69d5276704e1a9c771de57c0a2e7b69ea3ea578.tar.xz
kernel-qcow2-linux-c69d5276704e1a9c771de57c0a2e7b69ea3ea578.zip
drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c
Check overlay_ops is not NULL as checked in the previous 'if' condition. Fixes the following smatch error: drivers/gpu/drm/exynos/exynos_drm_encoder.c:509 exynos_drm_encoder_plane_disable() error: we previously assumed 'overlay_ops' could be null (see line 499) Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Inki Dae <inki.dae@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
-rw-r--r--drivers/gpu/drm/exynos/exynos_drm_encoder.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
index 607231a71b2d..f2df06c603f7 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
@@ -513,6 +513,6 @@ void exynos_drm_encoder_plane_disable(struct drm_encoder *encoder, void *data)
* because the setting for disabling the overlay will be updated
* at vsync.
*/
- if (overlay_ops->wait_for_vblank)
+ if (overlay_ops && overlay_ops->wait_for_vblank)
overlay_ops->wait_for_vblank(manager->dev);
}