summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRickard Strandqvist2014-05-18 18:02:57 +0200
committerBjorn Helgaas2014-05-28 04:51:14 +0200
commitcab9a128dad0fa0c8400a03d9375c781dda43982 (patch)
treed8d22dbf6548a0eca78e90b8f124c2b8d5cf9bf3
parentNVMe: Implement PCIe reset notification callback (diff)
downloadkernel-qcow2-linux-cab9a128dad0fa0c8400a03d9375c781dda43982.tar.gz
kernel-qcow2-linux-cab9a128dad0fa0c8400a03d9375c781dda43982.tar.xz
kernel-qcow2-linux-cab9a128dad0fa0c8400a03d9375c781dda43982.zip
PCI: cpqphp: Fix possible null pointer dereference
There is otherwise a risk of a null pointer dereference. Found by cppcheck, a static code analysis program. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
-rw-r--r--drivers/pci/hotplug/cpqphp_ctrl.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pci/hotplug/cpqphp_ctrl.c b/drivers/pci/hotplug/cpqphp_ctrl.c
index 11845b796799..f593585f2784 100644
--- a/drivers/pci/hotplug/cpqphp_ctrl.c
+++ b/drivers/pci/hotplug/cpqphp_ctrl.c
@@ -709,7 +709,8 @@ static struct pci_resource *get_max_resource(struct pci_resource **head, u32 siz
temp = temp->next;
}
- temp->next = max->next;
+ if (temp)
+ temp->next = max->next;
}
max->next = NULL;