diff options
| author | Chris Wilson | 2009-06-17 22:52:49 +0200 |
|---|---|---|
| committer | Eric Anholt | 2009-06-18 00:26:24 +0200 |
| commit | d78b47b9a527bf46cb6081555847facd6efd5f81 (patch) | |
| tree | dee4127eda7743ee2370057394418e6a2d742a2d | |
| parent | drm/i915: A few debugfs formatting fixes (diff) | |
| download | kernel-qcow2-linux-d78b47b9a527bf46cb6081555847facd6efd5f81.tar.gz kernel-qcow2-linux-d78b47b9a527bf46cb6081555847facd6efd5f81.tar.xz kernel-qcow2-linux-d78b47b9a527bf46cb6081555847facd6efd5f81.zip | |
drm/i915: detach/attach get/put pages symmetry
After performing an operation over the page list for a buffer retrieved by
i915_gem_object_get_pages() the pages need to be returned with
i915_gem_object_put_pages(). This was not being observed for the phys
objects which were thus leaking references to their backing pages.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
CC: Dave Airlie <airlied@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
| -rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index c0ae6bbbd9b5..a5f95ad3c072 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -4312,6 +4312,8 @@ void i915_gem_detach_phys_object(struct drm_device *dev, } drm_clflush_pages(obj_priv->pages, page_count); drm_agp_chipset_flush(dev); + + i915_gem_object_put_pages(obj); out: obj_priv->phys_obj->cur_obj = NULL; obj_priv->phys_obj = NULL; @@ -4369,6 +4371,8 @@ i915_gem_attach_phys_object(struct drm_device *dev, kunmap_atomic(src, KM_USER0); } + i915_gem_object_put_pages(obj); + return 0; out: return ret; |