summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEzequiel Garcia2019-05-03 00:00:43 +0200
committerGreg Kroah-Hartman2019-07-26 09:14:24 +0200
commitdeb78bd24e0cd196acffbedffb9bed7a8839b227 (patch)
tree4612017b307e3aadb9b3481a8a57f2d8eb1d8114
parentmedia: v4l2: Test type instead of cfg->type in v4l2_ctrl_new_custom() (diff)
downloadkernel-qcow2-linux-deb78bd24e0cd196acffbedffb9bed7a8839b227.tar.gz
kernel-qcow2-linux-deb78bd24e0cd196acffbedffb9bed7a8839b227.tar.xz
kernel-qcow2-linux-deb78bd24e0cd196acffbedffb9bed7a8839b227.zip
media: coda: Remove unbalanced and unneeded mutex unlock
commit 766b9b168f6c75c350dd87c3e0bc6a9b322f0013 upstream. The mutex unlock in the threaded interrupt handler is not paired with any mutex lock. Remove it. This bug has been here for a really long time, so it applies to any stable repo. Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/media/platform/coda/coda-bit.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c
index 925581d65ad8..c3eaddced721 100644
--- a/drivers/media/platform/coda/coda-bit.c
+++ b/drivers/media/platform/coda/coda-bit.c
@@ -2309,7 +2309,6 @@ irqreturn_t coda_irq_handler(int irq, void *data)
if (ctx == NULL) {
v4l2_err(&dev->v4l2_dev,
"Instance released before the end of transaction\n");
- mutex_unlock(&dev->coda_mutex);
return IRQ_HANDLED;
}