diff options
| author | Daniel Vetter | 2018-10-04 22:24:45 +0200 |
|---|---|---|
| committer | Daniel Vetter | 2018-10-05 18:05:32 +0200 |
| commit | e6a3e405b54804efbf50e97c8c4460099be03e1f (patch) | |
| tree | a6cdcdfaa97478543c7fd60af078687c44dd9825 | |
| parent | drm/doc: fix drm_driver_legacy_fb_format (diff) | |
| download | kernel-qcow2-linux-e6a3e405b54804efbf50e97c8c4460099be03e1f.tar.gz kernel-qcow2-linux-e6a3e405b54804efbf50e97c8c4460099be03e1f.tar.xz kernel-qcow2-linux-e6a3e405b54804efbf50e97c8c4460099be03e1f.zip | |
drm/todo: Add some cleanup tasks
Motivated by review comments from Ville&Sean.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Sean Paul <sean@poorly.run>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181004202446.22905-21-daniel.vetter@ffwll.ch
| -rw-r--r-- | Documentation/gpu/todo.rst | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 77c2b3c25565..5c9d86c962af 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -339,6 +339,16 @@ Some of these date from the very introduction of KMS in 2008 ... leftovers from older (never merged into upstream) KMS designs where modes where set using their ID, including support to add/remove modes. +- Make ->funcs and ->helper_private vtables optional. There's a bunch of empty + function tables in drivers, but before we can remove them we need to make sure + that all the users in helpers and drivers do correctly check for a NULL + vtable. + +- Cleanup up the various ->destroy callbacks. A lot of them just wrapt the + drm_*_cleanup implementations and can be removed. Some tack a kfree() at the + end, for which we could add drm_*_cleanup_kfree(). And then there's the (for + historical reasons) misnamed drm_primary_helper_destroy() function. + Better Testing ============== |