summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOleg Nesterov2007-10-17 08:26:59 +0200
committerLinus Torvalds2007-10-17 17:42:51 +0200
commitebca4cda1133775111e8b09f7124a7e5e391926d (patch)
tree074d2791b1e7b784aa6126012eeac38d505b2c06
parentexit_notify: don't take tasklist for TIF_SIGPENDING re-targeting (diff)
downloadkernel-qcow2-linux-ebca4cda1133775111e8b09f7124a7e5e391926d.tar.gz
kernel-qcow2-linux-ebca4cda1133775111e8b09f7124a7e5e391926d.tar.xz
kernel-qcow2-linux-ebca4cda1133775111e8b09f7124a7e5e391926d.zip
zap_other_threads: don't optimize thread_group_empty() case
Nowadays thread_group_empty() and next_thread() are simple list operations, this optimization doesn't make sense: we are doing exactly same check one line below. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Acked-by: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--kernel/signal.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/signal.c b/kernel/signal.c
index 2f7736ff7418..b7aa492e16ad 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -985,9 +985,6 @@ void zap_other_threads(struct task_struct *p)
p->signal->flags = SIGNAL_GROUP_EXIT;
p->signal->group_stop_count = 0;
- if (thread_group_empty(p))
- return;
-
for (t = next_thread(p); t != p; t = next_thread(t)) {
/*
* Don't bother with already dead threads