summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Herrenschmidt2009-12-01 15:36:28 +0100
committerBenjamin Herrenschmidt2009-12-09 07:09:27 +0100
commitf0353813afe784330622596ff141e7525ccd99de (patch)
treef1d2fd76b98026b4a6d524b640c18dd379532d26
parentpowerpc/macio: Rework hotplug media bay support (diff)
downloadkernel-qcow2-linux-f0353813afe784330622596ff141e7525ccd99de.tar.gz
kernel-qcow2-linux-f0353813afe784330622596ff141e7525ccd99de.tar.xz
kernel-qcow2-linux-f0353813afe784330622596ff141e7525ccd99de.zip
libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()
In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap->ops->bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Acked-by: Jeff Garzik <jgarzik@redhat.com>
-rw-r--r--drivers/ata/libata-sff.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index bbbb1fab1755..51eb1e298601 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct ata_queued_cmd *qc)
ap->hsm_task_state = HSM_ST_IDLE;
if (ap->ioaddr.bmdma_addr)
- ata_bmdma_stop(qc);
+ ap->ops->bmdma_stop(qc);
spin_unlock_irqrestore(ap->lock, flags);
}