diff options
| author | Wenwen Wang | 2019-08-14 20:56:43 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-08-18 22:03:21 +0200 |
| commit | f1472cb09f11ddb41d4be84f0650835cb65a9073 (patch) | |
| tree | e29a80bcb173a25a5f45ca91e8ab88b656de0a0a | |
| parent | cx82310_eth: fix a memory leak bug (diff) | |
| download | kernel-qcow2-linux-f1472cb09f11ddb41d4be84f0650835cb65a9073.tar.gz kernel-qcow2-linux-f1472cb09f11ddb41d4be84f0650835cb65a9073.tar.xz kernel-qcow2-linux-f1472cb09f11ddb41d4be84f0650835cb65a9073.zip | |
net: kalmia: fix memory leaks
In kalmia_init_and_get_ethernet_addr(), 'usb_buf' is allocated through
kmalloc(). In the following execution, if the 'status' returned by
kalmia_send_init_packet() is not 0, 'usb_buf' is not deallocated, leading
to memory leaks. To fix this issue, add the 'out' label to free 'usb_buf'.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/kalmia.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c index d62b6706a537..fc5895f85cee 100644 --- a/drivers/net/usb/kalmia.c +++ b/drivers/net/usb/kalmia.c @@ -113,16 +113,16 @@ kalmia_init_and_get_ethernet_addr(struct usbnet *dev, u8 *ethernet_addr) status = kalmia_send_init_packet(dev, usb_buf, ARRAY_SIZE(init_msg_1), usb_buf, 24); if (status != 0) - return status; + goto out; memcpy(usb_buf, init_msg_2, 12); status = kalmia_send_init_packet(dev, usb_buf, ARRAY_SIZE(init_msg_2), usb_buf, 28); if (status != 0) - return status; + goto out; memcpy(ethernet_addr, usb_buf + 10, ETH_ALEN); - +out: kfree(usb_buf); return status; } |