diff options
| author | Greg Kroah-Hartman | 2012-09-18 18:09:00 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2012-09-18 18:09:00 +0200 |
| commit | f378dfe4bef8d77dbd420a12bd75fd09395bc3d8 (patch) | |
| tree | 4c0fdb37b4f692a723116a3c052133222e4c3d30 | |
| parent | USB: serial: safe-serial: fix up printk() usage (diff) | |
| download | kernel-qcow2-linux-f378dfe4bef8d77dbd420a12bd75fd09395bc3d8.tar.gz kernel-qcow2-linux-f378dfe4bef8d77dbd420a12bd75fd09395bc3d8.tar.xz kernel-qcow2-linux-f378dfe4bef8d77dbd420a12bd75fd09395bc3d8.zip | |
USB: serial: ti_usb_3410_5052: fix up noisy printk() usage
The driver should not be sending any printk() messages when it is
loaded, as no other USB serial driver does. This fixes that, and also
removes the useless version number from the driver.
Cc: Johan Hovold <jhovold@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Adhir Ramjiawan <adhirramjiawan0@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/serial/ti_usb_3410_5052.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index e6f492d3d366..648249e74125 100644 --- a/drivers/usb/serial/ti_usb_3410_5052.c +++ b/drivers/usb/serial/ti_usb_3410_5052.c @@ -40,7 +40,6 @@ /* Defines */ -#define TI_DRIVER_VERSION "v0.10" #define TI_DRIVER_AUTHOR "Al Borchers <alborchers@steinerpoint.com>" #define TI_DRIVER_DESC "TI USB 3410/5052 Serial Driver" @@ -276,7 +275,6 @@ static struct usb_serial_driver * const serial_drivers[] = { MODULE_AUTHOR(TI_DRIVER_AUTHOR); MODULE_DESCRIPTION(TI_DRIVER_DESC); -MODULE_VERSION(TI_DRIVER_VERSION); MODULE_LICENSE("GPL"); MODULE_FIRMWARE("ti_3410.fw"); @@ -312,7 +310,6 @@ MODULE_DEVICE_TABLE(usb, ti_id_table_combined); static int __init ti_init(void) { int i, j, c; - int ret; /* insert extra vendor and product ids */ c = ARRAY_SIZE(ti_id_table_combined) - 2 * TI_EXTRA_VID_PID_COUNT - 1; @@ -335,11 +332,7 @@ static int __init ti_init(void) ti_id_table_combined[c].match_flags = USB_DEVICE_ID_MATCH_DEVICE; } - ret = usb_serial_register_drivers(serial_drivers, KBUILD_MODNAME, ti_id_table_combined); - if (ret == 0) - printk(KERN_INFO KBUILD_MODNAME ": " TI_DRIVER_VERSION ":" - TI_DRIVER_DESC "\n"); - return ret; + return usb_serial_register_drivers(serial_drivers, KBUILD_MODNAME, ti_id_table_combined); } static void __exit ti_exit(void) |