diff options
| author | Ben Hutchings | 2013-07-09 18:12:49 +0200 |
|---|---|---|
| committer | Ben Hutchings | 2013-08-21 15:18:12 +0200 |
| commit | f3851b0acc5a75bd33c6d344a2e4f920e1622ff0 (patch) | |
| tree | 2de77a2ec1d20de90314b055b82e15d71f97bbda | |
| parent | Merge tag 'clk-fixes-for-linus' of git://git.linaro.org/people/mturquette/linux (diff) | |
| download | kernel-qcow2-linux-f3851b0acc5a75bd33c6d344a2e4f920e1622ff0.tar.gz kernel-qcow2-linux-f3851b0acc5a75bd33c6d344a2e4f920e1622ff0.tar.xz kernel-qcow2-linux-f3851b0acc5a75bd33c6d344a2e4f920e1622ff0.zip | |
sfc: Fix lookup of default RX MAC filters when steered using ethtool
commit 385904f819e3 ('sfc: Don't use
efx_filter_{build,hash,increment}() for default MAC filters') used the
wrong name to find the index of default RX MAC filters at insertion/
update time. This could result in memory corruption and would in any
case silently fail to update the filter.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
| -rw-r--r-- | drivers/net/ethernet/sfc/filter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/filter.c b/drivers/net/ethernet/sfc/filter.c index 2a469b27a506..30d744235d27 100644 --- a/drivers/net/ethernet/sfc/filter.c +++ b/drivers/net/ethernet/sfc/filter.c @@ -675,7 +675,7 @@ s32 efx_filter_insert_filter(struct efx_nic *efx, struct efx_filter_spec *spec, BUILD_BUG_ON(EFX_FILTER_INDEX_UC_DEF != 0); BUILD_BUG_ON(EFX_FILTER_INDEX_MC_DEF != EFX_FILTER_MC_DEF - EFX_FILTER_UC_DEF); - rep_index = spec->type - EFX_FILTER_INDEX_UC_DEF; + rep_index = spec->type - EFX_FILTER_UC_DEF; ins_index = rep_index; spin_lock_bh(&state->lock); |