diff options
| author | J. Bruce Fields | 2007-11-20 22:52:07 +0100 |
|---|---|---|
| committer | J. Bruce Fields | 2008-02-01 22:42:05 +0100 |
| commit | f3aba4e5a1b963c8bd43394cb15fb9fb6a229cd2 (patch) | |
| tree | 9d4ad0e722f4266bac28450ca7a511eee9c22a5f | |
| parent | nfsd4: kill unnecessary same_name() in setclientid_confirm (diff) | |
| download | kernel-qcow2-linux-f3aba4e5a1b963c8bd43394cb15fb9fb6a229cd2.tar.gz kernel-qcow2-linux-f3aba4e5a1b963c8bd43394cb15fb9fb6a229cd2.tar.xz kernel-qcow2-linux-f3aba4e5a1b963c8bd43394cb15fb9fb6a229cd2.zip | |
nfsd4: remove unnecessary cl_verifier check from setclientid_confirm
Again, the only way conf and unconf can have the same clientid is if
they were created in the "probable callback update" case of setclientid,
in which case we already know that the cl_verifier fields must agree.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
| -rw-r--r-- | fs/nfsd/nfs4state.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index df3e7a7ad31e..23b5fc71f9fb 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -837,7 +837,6 @@ nfsd4_setclientid_confirm(struct svc_rqst *rqstp, */ if ((conf && unconf) && (same_verf(&unconf->cl_confirm, &confirm)) && - (same_verf(&conf->cl_verifier, &unconf->cl_verifier)) && (!same_verf(&conf->cl_confirm, &unconf->cl_confirm))) { /* * RFC 3530 14.2.34 CASE 1: @@ -855,9 +854,7 @@ nfsd4_setclientid_confirm(struct svc_rqst *rqstp, status = nfs_ok; } - } else if ((conf && !unconf) || - ((conf && unconf) && - !same_verf(&conf->cl_verifier, &unconf->cl_verifier))) { + } else if (conf && !unconf) { /* * RFC 3530 14.2.34 CASE 2: * probable retransmitted request; play it safe and |