diff options
| author | Julia Lawall | 2008-12-17 00:43:29 +0100 |
|---|---|---|
| committer | David S. Miller | 2008-12-17 00:43:29 +0100 |
| commit | f40e0638237a2d3e2ce8bedf3af4b3c02cf6fff7 (patch) | |
| tree | c70b1a86681bd827fd0d7028cef391042f344e79 | |
| parent | phylib: Remove unnecessary "reset" fixups in genphy_setup_forced (diff) | |
| download | kernel-qcow2-linux-f40e0638237a2d3e2ce8bedf3af4b3c02cf6fff7.tar.gz kernel-qcow2-linux-f40e0638237a2d3e2ce8bedf3af4b3c02cf6fff7.tar.xz kernel-qcow2-linux-f40e0638237a2d3e2ce8bedf3af4b3c02cf6fff7.zip | |
drivers/net/hamradio: Move a dereference below a NULL test
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/hamradio/mkiss.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 7570c73f18c0..bbdb311b8420 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -846,12 +846,13 @@ static int mkiss_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg) { struct mkiss *ax = mkiss_get(tty); - struct net_device *dev = ax->dev; + struct net_device *dev; unsigned int tmp, err; /* First make sure we're connected. */ if (ax == NULL) return -ENXIO; + dev = ax->dev; switch (cmd) { case SIOCGIFNAME: |