diff options
| author | Felix Fietkau | 2012-02-05 21:15:17 +0100 |
|---|---|---|
| committer | John W. Linville | 2012-02-06 17:34:02 +0100 |
| commit | f88373fa47f3ce6590fdfaa742d0ddacc2ae017f (patch) | |
| tree | 806086755a4ba5bb35674d8960bccce552d1c3cc | |
| parent | mwifiex: add NULL checks in driver unload path (diff) | |
| download | kernel-qcow2-linux-f88373fa47f3ce6590fdfaa742d0ddacc2ae017f.tar.gz kernel-qcow2-linux-f88373fa47f3ce6590fdfaa742d0ddacc2ae017f.tar.xz kernel-qcow2-linux-f88373fa47f3ce6590fdfaa742d0ddacc2ae017f.zip | |
ath9k: fix a WEP crypto related regression
commit b4a82a0 "ath9k_hw: fix interpretation of the rx KeyMiss flag"
fixed the interpretation of the KeyMiss flag for keycache based lookups,
however WEP encryption uses a static index, so KeyMiss is always asserted
for it, even though frames are decrypted properly.
Fix this by clearing the ATH9K_RXERR_KEYMISS flag if no keycache based
lookup was performed.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Cc: stable@vger.kernel.org
Reported-by: Laurent Bonnans <bonnans.l@gmail.com>
Reported-by: Jurica Vukadin <u.ra604@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| -rw-r--r-- | drivers/net/wireless/ath/ath9k/recv.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c index 0e666fbe0842..7e1a91af1497 100644 --- a/drivers/net/wireless/ath/ath9k/recv.c +++ b/drivers/net/wireless/ath/ath9k/recv.c @@ -822,6 +822,14 @@ static bool ath9k_rx_accept(struct ath_common *common, (ATH9K_RXERR_DECRYPT | ATH9K_RXERR_CRC | ATH9K_RXERR_MIC | ATH9K_RXERR_KEYMISS)); + /* + * Key miss events are only relevant for pairwise keys where the + * descriptor does contain a valid key index. This has been observed + * mostly with CCMP encryption. + */ + if (rx_stats->rs_keyix == ATH9K_RXKEYIX_INVALID) + rx_stats->rs_status &= ~ATH9K_RXERR_KEYMISS; + if (!rx_stats->rs_datalen) return false; /* |