summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGustavo A. R. Silva2018-06-15 15:32:28 +0200
committerAlex Deucher2018-06-15 18:47:15 +0200
commitfe78627d430435d22316fe39f2012ece31bf23c2 (patch)
treec06c8144b917c531fbf12dc488c78c4f5e7493a0
parentdrm/amdgpu: Fix uvd firmware version information for vega20 (v2) (diff)
downloadkernel-qcow2-linux-fe78627d430435d22316fe39f2012ece31bf23c2.tar.gz
kernel-qcow2-linux-fe78627d430435d22316fe39f2012ece31bf23c2.tar.xz
kernel-qcow2-linux-fe78627d430435d22316fe39f2012ece31bf23c2.zip
drm/amd/display: fix type of variable
Currently, the maximum value that *counter* can reach is 255, and code at line 150: while (counter < 1000) { implies a bigger value could be expected. Fix this by changing the type of variable *counter* from uint8_t to uint16_t. Addresses-Coverity-ID: 1470030 ("Operands don't affect result") Fixes: 2b6199a1d1b7 ("drm/amd/display: replace msleep with udelay in fbc path") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
index e2994d337044..111c4921987f 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
@@ -143,7 +143,7 @@ static void wait_for_fbc_state_changed(
struct dce110_compressor *cp110,
bool enabled)
{
- uint8_t counter = 0;
+ uint16_t counter = 0;
uint32_t addr = mmFBC_STATUS;
uint32_t value;