diff options
| author | Oleg Nesterov | 2013-02-28 02:02:52 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2013-02-28 04:10:09 +0100 |
| commit | 7ff6764061ecd4a4ef91db7b8b30aacc6a8573c9 (patch) | |
| tree | 4b98078f0919f60c4ae60190c2cf0b6e495fafaf /MAINTAINERS | |
| parent | mm: use vm_unmapped_area() on frv architecture (diff) | |
| download | kernel-qcow2-linux-7ff6764061ecd4a4ef91db7b8b30aacc6a8573c9.tar.gz kernel-qcow2-linux-7ff6764061ecd4a4ef91db7b8b30aacc6a8573c9.tar.xz kernel-qcow2-linux-7ff6764061ecd4a4ef91db7b8b30aacc6a8573c9.zip | |
usermodehelper: cleanup/fix __orderly_poweroff() && argv_free()
__orderly_poweroff() does argv_free() if call_usermodehelper_fns()
returns -ENOMEM. As Lucas pointed out, this can be wrong if -ENOMEM was
not triggered by the failing call_usermodehelper_setup(), in this case
both __orderly_poweroff() and argv_cleanup() can do kfree().
Kill argv_cleanup() and change __orderly_poweroff() to call argv_free()
unconditionally like do_coredump() does. This info->cleanup() is not
needed (and wrong) since 6c0c0d4d "fix bug in orderly_poweroff() which
did the UMH_NO_WAIT => UMH_WAIT_EXEC change, we can rely on the fact
that CLONE_VFORK can't return until do_execve() succeeds/fails.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: David Howells <dhowells@redhat.com>
Cc: James Morris <james.l.morris@oracle.com>
Cc: hongfeng <hongfeng@marvell.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions