diff options
| author | Daniel Lezcano | 2013-01-19 06:57:58 +0100 |
|---|---|---|
| committer | Kukjin Kim | 2013-04-09 17:12:26 +0200 |
| commit | 5db9f436213d81f053e3f6d69d367637b02fe95e (patch) | |
| tree | e567e034340e9e32ccb24b7c80c6a8edae0bf56b /arch/arm/mach-exynos/cpuidle.c | |
| parent | ARM: EXYNOS: factor out the idle states (diff) | |
| download | kernel-qcow2-linux-5db9f436213d81f053e3f6d69d367637b02fe95e.tar.gz kernel-qcow2-linux-5db9f436213d81f053e3f6d69d367637b02fe95e.tar.xz kernel-qcow2-linux-5db9f436213d81f053e3f6d69d367637b02fe95e.zip | |
ARM: EXYNOS: handle properly the return values
The cpuidle_register_driver return value is not checked.
The init function returns always -EIO when cpuidle_register_device
fails but the error could be different.
This patch fixes that by checking the cpuidle_register_driver properly
and returning the correct value when cpuidle_register_device fails.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Diffstat (limited to 'arch/arm/mach-exynos/cpuidle.c')
| -rw-r--r-- | arch/arm/mach-exynos/cpuidle.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 6ac4069f3c93..a4e50811c9c5 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -194,13 +194,17 @@ static void __init exynos5_core_down_clk(void) static int __init exynos4_init_cpuidle(void) { - int cpu_id; + int cpu_id, ret; struct cpuidle_device *device; if (soc_is_exynos5250()) exynos5_core_down_clk(); - cpuidle_register_driver(&exynos4_idle_driver); + ret = cpuidle_register_driver(&exynos4_idle_driver); + if (ret) { + printk(KERN_ERR "CPUidle failed to register driver\n"); + return ret; + } for_each_cpu(cpu_id, cpu_online_mask) { device = &per_cpu(exynos4_cpuidle_device, cpu_id); @@ -210,9 +214,10 @@ static int __init exynos4_init_cpuidle(void) if (cpu_id != 0) device->state_count = 1; - if (cpuidle_register_device(device)) { - printk(KERN_ERR "CPUidle register device failed\n,"); - return -EIO; + ret = cpuidle_register_device(device); + if (ret) { + printk(KERN_ERR "CPUidle register device failed\n"); + return ret; } } |