summaryrefslogtreecommitdiffstats
path: root/arch/arm/mach-mx5/imx53-dt.c
diff options
context:
space:
mode:
authorShawn Guo2011-12-01 07:35:29 +0100
committerShawn Guo2011-12-01 09:11:55 +0100
commit2a3267a489f1dc4284b64a4b88c62011946dc7ff (patch)
treeb2e33b58cc6b6220645f05889a6f8e10dbbfe82f /arch/arm/mach-mx5/imx53-dt.c
parentLinux 3.2-rc3 (diff)
downloadkernel-qcow2-linux-2a3267a489f1dc4284b64a4b88c62011946dc7ff.tar.gz
kernel-qcow2-linux-2a3267a489f1dc4284b64a4b88c62011946dc7ff.tar.xz
kernel-qcow2-linux-2a3267a489f1dc4284b64a4b88c62011946dc7ff.zip
arm/imx: fix return type of callback passed to of_irq_init()
The of_irq_init() expects the callback passed by .data of of_device_id return 'int' instead of 'void'. This patch fixes it to have irq_init_cb() return the correct value, and in turn have the secondary interrupt controller (gpio in this case) initialized properly and also eliminate the error message 'of_irq_init: children remain, but no parents' which was overlooked before. Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Diffstat (limited to 'arch/arm/mach-mx5/imx53-dt.c')
-rw-r--r--arch/arm/mach-mx5/imx53-dt.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/arch/arm/mach-mx5/imx53-dt.c b/arch/arm/mach-mx5/imx53-dt.c
index ccaa0b81b768..022bc0364b5f 100644
--- a/arch/arm/mach-mx5/imx53-dt.c
+++ b/arch/arm/mach-mx5/imx53-dt.c
@@ -48,13 +48,14 @@ static const struct of_dev_auxdata imx53_auxdata_lookup[] __initconst = {
{ /* sentinel */ }
};
-static void __init imx53_tzic_add_irq_domain(struct device_node *np,
+static int __init imx53_tzic_add_irq_domain(struct device_node *np,
struct device_node *interrupt_parent)
{
irq_domain_add_simple(np, 0);
+ return 0;
}
-static void __init imx53_gpio_add_irq_domain(struct device_node *np,
+static int __init imx53_gpio_add_irq_domain(struct device_node *np,
struct device_node *interrupt_parent)
{
static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS -
@@ -62,6 +63,8 @@ static void __init imx53_gpio_add_irq_domain(struct device_node *np,
irq_domain_add_simple(np, gpio_irq_base);
gpio_irq_base += 32;
+
+ return 0;
}
static const struct of_device_id imx53_irq_match[] __initconst = {