diff options
| author | James Hogan | 2016-11-28 18:23:14 +0100 |
|---|---|---|
| committer | James Hogan | 2017-02-03 16:21:06 +0100 |
| commit | 122e51d47418f74a69a93bf02f5535d11ff75bf5 (patch) | |
| tree | 38aad30f6698d4397b75e0f9f05f2c03f6ea2db6 /arch/mips/kvm/entry.c | |
| parent | KVM: MIPS/T&E: Don't treat code fetch faults as MMIO (diff) | |
| download | kernel-qcow2-linux-122e51d47418f74a69a93bf02f5535d11ff75bf5.tar.gz kernel-qcow2-linux-122e51d47418f74a69a93bf02f5535d11ff75bf5.tar.xz kernel-qcow2-linux-122e51d47418f74a69a93bf02f5535d11ff75bf5.zip | |
KVM: MIPS: Improve kvm_get_inst() error return
Currently kvm_get_inst() returns KVM_INVALID_INST in the event of a
fault reading the guest instruction. This has the rather arbitrary magic
value 0xdeadbeef. This API isn't very robust, and in fact 0xdeadbeef is
a valid MIPS64 instruction encoding, namely "ld t1,-16657(s5)".
Therefore change the kvm_get_inst() API to return 0 or -EFAULT, and to
return the instruction via a u32 *out argument. We can then drop the
KVM_INVALID_INST definition entirely.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: kvm@vger.kernel.org
Diffstat (limited to 'arch/mips/kvm/entry.c')
0 files changed, 0 insertions, 0 deletions