summaryrefslogtreecommitdiffstats
path: root/arch/mips/vr41xx
diff options
context:
space:
mode:
authorRoel Kluin2007-11-15 02:00:06 +0100
committerLinus Torvalds2007-11-15 03:45:42 +0100
commitc0f2a9d75aed1a4be40c3975b94fd39066bd11bb (patch)
tree9d73066a4d79d07dd8da0d3eece2924b7308292b /arch/mips/vr41xx
parentcris gpio: undo locks before returning (diff)
downloadkernel-qcow2-linux-c0f2a9d75aed1a4be40c3975b94fd39066bd11bb.tar.gz
kernel-qcow2-linux-c0f2a9d75aed1a4be40c3975b94fd39066bd11bb.tar.xz
kernel-qcow2-linux-c0f2a9d75aed1a4be40c3975b94fd39066bd11bb.zip
mips: undo locking on error path returns
[akpm@linux-foundation.org: coding-style cleanups] Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Cc: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/mips/vr41xx')
-rw-r--r--arch/mips/vr41xx/common/icu.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/mips/vr41xx/common/icu.c b/arch/mips/vr41xx/common/icu.c
index 1899601e5862..3f23d9fda662 100644
--- a/arch/mips/vr41xx/common/icu.c
+++ b/arch/mips/vr41xx/common/icu.c
@@ -525,6 +525,7 @@ static inline int set_sysint1_assign(unsigned int irq, unsigned char assign)
intassign1 |= (uint16_t)assign << 9;
break;
default:
+ spin_unlock_irq(&desc->lock);
return -EINVAL;
}
@@ -592,6 +593,7 @@ static inline int set_sysint2_assign(unsigned int irq, unsigned char assign)
intassign3 |= (uint16_t)assign << 12;
break;
default:
+ spin_unlock_irq(&desc->lock);
return -EINVAL;
}