diff options
| author | Thomas Gleixner | 2019-04-10 12:28:02 +0200 |
|---|---|---|
| committer | Thomas Gleixner | 2019-04-14 19:58:29 +0200 |
| commit | 4f3bd6ca310b594df09c8f1e319cda9baf502ec8 (patch) | |
| tree | bb8051546444a3f526cd8baa5758ea597a39e0db /arch/parisc | |
| parent | arm64/stacktrace: Remove the pointless ULONG_MAX marker (diff) | |
| download | kernel-qcow2-linux-4f3bd6ca310b594df09c8f1e319cda9baf502ec8.tar.gz kernel-qcow2-linux-4f3bd6ca310b594df09c8f1e319cda9baf502ec8.tar.xz kernel-qcow2-linux-4f3bd6ca310b594df09c8f1e319cda9baf502ec8.zip | |
parisc/stacktrace: Remove the pointless ULONG_MAX marker
Terminating the last trace entry with ULONG_MAX is a completely pointless
exercise and none of the consumers can rely on it because it's
inconsistently implemented across architectures. In fact quite some of the
callers remove the entry and adjust stack_trace.nr_entries afterwards.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org
Link: https://lkml.kernel.org/r/20190410103644.308534788@linutronix.de
Diffstat (limited to 'arch/parisc')
| -rw-r--r-- | arch/parisc/kernel/stacktrace.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/arch/parisc/kernel/stacktrace.c b/arch/parisc/kernel/stacktrace.c index ec5835e83a7a..6f0b9c8d8052 100644 --- a/arch/parisc/kernel/stacktrace.c +++ b/arch/parisc/kernel/stacktrace.c @@ -29,22 +29,17 @@ static void dump_trace(struct task_struct *task, struct stack_trace *trace) } } - /* * Save stack-backtrace addresses into a stack_trace buffer. */ void save_stack_trace(struct stack_trace *trace) { dump_trace(current, trace); - if (trace->nr_entries < trace->max_entries) - trace->entries[trace->nr_entries++] = ULONG_MAX; } EXPORT_SYMBOL_GPL(save_stack_trace); void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) { dump_trace(tsk, trace); - if (trace->nr_entries < trace->max_entries) - trace->entries[trace->nr_entries++] = ULONG_MAX; } EXPORT_SYMBOL_GPL(save_stack_trace_tsk); |