diff options
author | Kevin Hao | 2013-08-06 12:23:30 +0200 |
---|---|---|
committer | Benjamin Herrenschmidt | 2013-08-14 06:56:06 +0200 |
commit | abb29c3bb13c7b747fae18b9c63b660529ccc612 (patch) | |
tree | 7db47abfcb4fd1ed18fc8942aeffed6ce176e0e5 /arch/powerpc/kernel/misc_32.S | |
parent | powerpc: Stop using non-architected shared_proc field in lppaca (diff) | |
download | kernel-qcow2-linux-abb29c3bb13c7b747fae18b9c63b660529ccc612.tar.gz kernel-qcow2-linux-abb29c3bb13c7b747fae18b9c63b660529ccc612.tar.xz kernel-qcow2-linux-abb29c3bb13c7b747fae18b9c63b660529ccc612.zip |
powerpc: Move the testing of CPU_FTR_COHERENT_ICACHE into __flush_icache_range
In function flush_icache_range(), we use cpu_has_feature() to test
the feature bit of CPU_FTR_COHERENT_ICACHE. But this seems not optimal
for two reasons:
a) For ppc32, the function __flush_icache_range() already do this
check with the macro END_FTR_SECTION_IFSET.
b) Compare with the cpu_has_feature(), the method of using macro
END_FTR_SECTION_IFSET will not introduce any runtime overhead.
[And while at it, add the missing required isync] -- BenH
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/kernel/misc_32.S')
-rw-r--r-- | arch/powerpc/kernel/misc_32.S | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S index e469f30e6eeb..1722a2be66ca 100644 --- a/arch/powerpc/kernel/misc_32.S +++ b/arch/powerpc/kernel/misc_32.S @@ -329,6 +329,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_UNIFIED_ID_CACHE) */ _KPROBE(__flush_icache_range) BEGIN_FTR_SECTION + isync blr /* for 601, do nothing */ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) li r5,L1_CACHE_BYTES-1 |