diff options
| author | Mathieu Malaterre | 2018-03-07 21:34:35 +0100 |
|---|---|---|
| committer | Michael Ellerman | 2018-03-13 05:50:41 +0100 |
| commit | 603b892200e653dd7e86a0e4a315561534d97441 (patch) | |
| tree | 11be6d7b2f7a58b0d71a61ba31cecdbfa48580a7 /arch/powerpc/mm/init_32.c | |
| parent | powerpc/prom: Remove warning on array size when empty (diff) | |
| download | kernel-qcow2-linux-603b892200e653dd7e86a0e4a315561534d97441.tar.gz kernel-qcow2-linux-603b892200e653dd7e86a0e4a315561534d97441.tar.xz kernel-qcow2-linux-603b892200e653dd7e86a0e4a315561534d97441.zip | |
powerpc: Avoid comparison of unsigned long >= 0 in pfn_valid()
Rewrite comparison since all values compared are of type `unsigned long`.
Instead of using unsigned properties and rewriting the original code as:
(originally suggested by Segher Boessenkool <segher@kernel.crashing.org>)
#define pfn_valid(pfn) \
(((pfn) - ARCH_PFN_OFFSET) < (max_mapnr - ARCH_PFN_OFFSET))
Prefer a static inline function to make code as readable as possible.
Fix a warning (treated as error in W=1):
arch/powerpc/include/asm/page.h:129:32: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
#define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < max_mapnr)
^
Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/mm/init_32.c')
0 files changed, 0 insertions, 0 deletions