diff options
| author | Daniel Axtens | 2015-03-31 07:00:41 +0200 |
|---|---|---|
| committer | Michael Ellerman | 2015-04-11 12:49:10 +0200 |
| commit | c88c2a188905cb3077c3c38dc498e7e9f8eebeee (patch) | |
| tree | 36fd0a09d7edba5db25562836d3228c6a823fd5f /arch/powerpc/platforms/powernv/pci-ioda.c | |
| parent | powerpc/powermac: move pmac_pci_probe_mode from setup.c to pci.c (diff) | |
| download | kernel-qcow2-linux-c88c2a188905cb3077c3c38dc498e7e9f8eebeee.tar.gz kernel-qcow2-linux-c88c2a188905cb3077c3c38dc498e7e9f8eebeee.tar.xz kernel-qcow2-linux-c88c2a188905cb3077c3c38dc498e7e9f8eebeee.zip | |
powerpc: pcibios_enable_device_hook: return bool rather than int
pcibios_enable_device_hook returned an int. Every implementation
returned either -EINVAL or 0. The return value wasn't propagated by
the caller: any non-zero return value caused pcibios_enable_device
to return -EINVAL itself. Therefore, make the hook return a bool.
Signed-off-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/platforms/powernv/pci-ioda.c')
| -rw-r--r-- | arch/powerpc/platforms/powernv/pci-ioda.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index 76b344125cef..f93d6c2bd743 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -1911,7 +1911,7 @@ static resource_size_t pnv_pci_window_alignment(struct pci_bus *bus, /* Prevent enabling devices for which we couldn't properly * assign a PE */ -static int pnv_pci_enable_device_hook(struct pci_dev *dev) +static bool pnv_pci_enable_device_hook(struct pci_dev *dev) { struct pci_controller *hose = pci_bus_to_host(dev->bus); struct pnv_phb *phb = hose->private_data; @@ -1923,13 +1923,13 @@ static int pnv_pci_enable_device_hook(struct pci_dev *dev) * PEs isn't ready. */ if (!phb->initialized) - return 0; + return true; pdn = pci_get_pdn(dev); if (!pdn || pdn->pe_number == IODA_INVALID_PE) - return -EINVAL; + return false; - return 0; + return true; } static u32 pnv_ioda_bdfn_to_pe(struct pnv_phb *phb, struct pci_bus *bus, |