summaryrefslogtreecommitdiffstats
path: root/arch/powerpc/platforms
diff options
context:
space:
mode:
authorBreno Leitao2018-09-25 16:29:33 +0200
committerMichael Ellerman2018-10-03 07:40:05 +0200
commit62dea077f56728979e40a741c8a0941dca7290e8 (patch)
tree6de20a6ba9f735296035ca38f82b72934f36ccd8 /arch/powerpc/platforms
parentselftests/powerpc: New PTRACE_SYSEMU test (diff)
downloadkernel-qcow2-linux-62dea077f56728979e40a741c8a0941dca7290e8.tar.gz
kernel-qcow2-linux-62dea077f56728979e40a741c8a0941dca7290e8.tar.xz
kernel-qcow2-linux-62dea077f56728979e40a741c8a0941dca7290e8.zip
powerpc/powernv: Mark function as __noreturn
There is a mismatch between function pnv_platform_error_reboot() definition and declaration regarding function modifiers. In the declaration part, it contains the function attribute __noreturn, while function definition itself lacks it. This was reported by sparse tool as an error: arch/powerpc/platforms/powernv/opal.c:538:6: error: symbol 'pnv_platform_error_reboot' redeclared with different type (originally declared at arch/powerpc/platforms/powernv/powernv.h:11) - different modifiers I checked and the function is already being considered as being 'noreturn' by the compiler, thus, I understand this patch does not change any code being generated. Signed-off-by: Breno Leitao <leitao@debian.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/platforms')
-rw-r--r--arch/powerpc/platforms/powernv/opal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 62c291e23dbe..06bf532fa000 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -535,7 +535,7 @@ static int opal_recover_mce(struct pt_regs *regs,
return recovered;
}
-void pnv_platform_error_reboot(struct pt_regs *regs, const char *msg)
+void __noreturn pnv_platform_error_reboot(struct pt_regs *regs, const char *msg)
{
panic_flush_kmsg_start();