diff options
| author | Michael Ellerman | 2008-05-26 04:12:32 +0200 |
|---|---|---|
| committer | Paul Mackerras | 2008-06-09 05:51:16 +0200 |
| commit | 19fc65b5251dfd90312ae0142cc8650cd273e6a6 (patch) | |
| tree | 2b61ab4405dce8bd17e76584821856ea3baabd88 /arch/powerpc/sysdev/uic.c | |
| parent | powerpc: Rework qe_ic_init() so we can avoid freeing the irq_host (diff) | |
| download | kernel-qcow2-linux-19fc65b5251dfd90312ae0142cc8650cd273e6a6.tar.gz kernel-qcow2-linux-19fc65b5251dfd90312ae0142cc8650cd273e6a6.tar.xz kernel-qcow2-linux-19fc65b5251dfd90312ae0142cc8650cd273e6a6.zip | |
powerpc: Fix irq_alloc_host() reference counting and callers
When I changed irq_alloc_host() to take an of_node
(52964f87c64e6c6ea671b5bf3030fb1494090a48: "Add an optional
device_node pointer to the irq_host"), I botched the reference
counting semantics.
Stephen pointed out that it's irq_alloc_host()'s business if
it needs to take an additional reference to the device_node,
the caller shouldn't need to care.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/sysdev/uic.c')
| -rw-r--r-- | arch/powerpc/sysdev/uic.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c index 625b275c3795..d35405c59434 100644 --- a/arch/powerpc/sysdev/uic.c +++ b/arch/powerpc/sysdev/uic.c @@ -280,12 +280,10 @@ static struct uic * __init uic_init_one(struct device_node *node) } uic->dcrbase = *dcrreg; - uic->irqhost = irq_alloc_host(of_node_get(node), IRQ_HOST_MAP_LINEAR, + uic->irqhost = irq_alloc_host(node, IRQ_HOST_MAP_LINEAR, NR_UIC_INTS, &uic_host_ops, -1); - if (! uic->irqhost) { - of_node_put(node); + if (! uic->irqhost) return NULL; /* FIXME: panic? */ - } uic->irqhost->host_data = uic; |