diff options
| author | Paolo 'Blaisorblade' Giarrusso | 2005-09-23 06:44:21 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2005-09-23 07:17:37 +0200 |
| commit | 79ae2cb856ed6a8c48f455d52d5ed5960c671e67 (patch) | |
| tree | b72431f31bb99e03d86c40cbfb17e766034ac2ef /arch/um/drivers/chan_kern.c | |
| parent | [PATCH] uml: Fix GFP_ flags usage (diff) | |
| download | kernel-qcow2-linux-79ae2cb856ed6a8c48f455d52d5ed5960c671e67.tar.gz kernel-qcow2-linux-79ae2cb856ed6a8c48f455d52d5ed5960c671e67.tar.xz kernel-qcow2-linux-79ae2cb856ed6a8c48f455d52d5ed5960c671e67.zip | |
[PATCH] uml: use GFP_ATOMIC for allocations under spinlocks.
setup_initial_poll is only called with sigio_lock() held, so use appropriate
allocation.
Also, parse_chan() can also be called when holding a spinlock (see line_open()
-> parse_chan_pair()).
I have sporadic problems (spinlock taken twice, with spinlock debugging on UP)
which could be caused by a sequence like "take spinlock, alloc and go to
sleep, take again the spinlock in the other thread".
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/um/drivers/chan_kern.c')
| -rw-r--r-- | arch/um/drivers/chan_kern.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/um/drivers/chan_kern.c b/arch/um/drivers/chan_kern.c index 14a12d6b3df6..244e54a2153b 100644 --- a/arch/um/drivers/chan_kern.c +++ b/arch/um/drivers/chan_kern.c @@ -465,7 +465,7 @@ static struct chan *parse_chan(char *str, int pri, int device, data = (*ops->init)(str, device, opts); if(data == NULL) return(NULL); - chan = kmalloc(sizeof(*chan), GFP_KERNEL); + chan = kmalloc(sizeof(*chan), GFP_ATOMIC); if(chan == NULL) return(NULL); *chan = ((struct chan) { .list = LIST_HEAD_INIT(chan->list), .primary = 1, |