diff options
| author | Paolo Bonzini | 2015-04-23 13:20:18 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2015-04-27 15:49:30 +0200 |
| commit | 73459e2a1ada09a68c02cc5b73f3116fc8194b3d (patch) | |
| tree | 2d85beb72d2ee970926f65554099764e2cdc1f9c /arch/x86/include/asm/pvclock.h | |
| parent | kvm: x86: fix kvmclock update protocol (diff) | |
| download | kernel-qcow2-linux-73459e2a1ada09a68c02cc5b73f3116fc8194b3d.tar.gz kernel-qcow2-linux-73459e2a1ada09a68c02cc5b73f3116fc8194b3d.tar.xz kernel-qcow2-linux-73459e2a1ada09a68c02cc5b73f3116fc8194b3d.zip | |
x86: pvclock: Really remove the sched notifier for cross-cpu migrations
This reverts commits 0a4e6be9ca17c54817cf814b4b5aa60478c6df27
and 80f7fdb1c7f0f9266421f823964fd1962681f6ce.
The task migration notifier was originally introduced in order to support
the pvclock vsyscall with non-synchronized TSC, but KVM only supports it
with synchronized TSC. Hence, on KVM the race condition is only needed
due to a bad implementation on the host side, and even then it's so rare
that it's mostly theoretical.
As far as KVM is concerned it's possible to fix the host, avoiding the
additional complexity in the vDSO and the (re)introduction of the task
migration notifier.
Xen, on the other hand, hasn't yet implemented vsyscall support at
all, so we do not care about its plans for non-synchronized TSC.
Reported-by: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86/include/asm/pvclock.h')
| -rw-r--r-- | arch/x86/include/asm/pvclock.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h index 25b1cc07d496..d6b078e9fa28 100644 --- a/arch/x86/include/asm/pvclock.h +++ b/arch/x86/include/asm/pvclock.h @@ -95,7 +95,6 @@ unsigned __pvclock_read_cycles(const struct pvclock_vcpu_time_info *src, struct pvclock_vsyscall_time_info { struct pvclock_vcpu_time_info pvti; - u32 migrate_count; } __attribute__((__aligned__(SMP_CACHE_BYTES))); #define PVTI_SIZE sizeof(struct pvclock_vsyscall_time_info) |