diff options
| author | Weidong Han | 2009-04-17 10:42:13 +0200 |
|---|---|---|
| committer | Ingo Molnar | 2009-04-19 10:21:33 +0200 |
| commit | 5d0ae2db6deac4f15dac4f42f23bc56448fc8d4d (patch) | |
| tree | 6f823dfb3cdf43dcf0f41f4e6b7297daa6742d0f /arch/x86/kernel/apic/apic.c | |
| parent | docs, x86: add nox2apic back to kernel-parameters.txt (diff) | |
| download | kernel-qcow2-linux-5d0ae2db6deac4f15dac4f42f23bc56448fc8d4d.tar.gz kernel-qcow2-linux-5d0ae2db6deac4f15dac4f42f23bc56448fc8d4d.tar.xz kernel-qcow2-linux-5d0ae2db6deac4f15dac4f42f23bc56448fc8d4d.zip | |
x86, intr-remap: fix ack for interrupt remapping
Shouldn't call ack_apic_edge() in ir_ack_apic_edge(), because
ack_apic_edge() does more than just ack: it also does irq migration
in the non-interrupt-remapping case. But there is no such need for
interrupt-remapping case, as irq migration is done in the process
context.
Similarly, ir_ack_apic_level() shouldn't call ack_apic_level, and
instead should do the local cpu's EOI + directed EOI to the io-apic.
ack_x2APIC_irq() is not neccessary, because ack_APIC_irq() will use MSR
write for x2apic, and uncached write for non-x2apic.
[ Impact: simplify/standardize intr-remap IRQ acking, fix on !x2apic ]
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Weidong Han <weidong.han@intel.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: iommu@lists.linux-foundation.org
Cc: allen.m.kay@intel.com
Cc: fenghua.yu@intel.com
LKML-Reference: <1239957736-6161-3-git-send-email-weidong.han@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/apic/apic.c')
0 files changed, 0 insertions, 0 deletions