diff options
| author | Sean Christopherson | 2019-04-16 22:32:47 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2019-04-30 21:32:17 +0200 |
| commit | 4ca88b3f86cd03deecd48ca9880a7c2e7c6fb788 (patch) | |
| tree | 8f34de9438c5c9c4fa50df89a8c1496d014499bb /arch/x86/kvm/lapic.c | |
| parent | KVM: lapic: Refactor ->set_hv_timer to use an explicit expired param (diff) | |
| download | kernel-qcow2-linux-4ca88b3f86cd03deecd48ca9880a7c2e7c6fb788.tar.gz kernel-qcow2-linux-4ca88b3f86cd03deecd48ca9880a7c2e7c6fb788.tar.xz kernel-qcow2-linux-4ca88b3f86cd03deecd48ca9880a7c2e7c6fb788.zip | |
KVM: lapic: Check for a pending timer intr prior to start_hv_timer()
Checking for a pending non-periodic interrupt in start_hv_timer() leads
to restart_apic_timer() making an unnecessary call to start_sw_timer()
due to start_hv_timer() returning false.
Alternatively, start_hv_timer() could return %true when there is a
pending non-periodic interrupt, but that approach is less intuitive,
i.e. would require a beefy comment to explain an otherwise simple check.
Cc: Liran Alon <liran.alon@oracle.com>
Cc: Wanpeng Li <wanpengli@tencent.com>
Suggested-by: Liran Alon <liran.alon@oracle.com>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86/kvm/lapic.c')
| -rw-r--r-- | arch/x86/kvm/lapic.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 0fd58571c453..4e000712cb82 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -1680,9 +1680,6 @@ static bool start_hv_timer(struct kvm_lapic *apic) if (!kvm_x86_ops->set_hv_timer) return false; - if (!apic_lvtt_period(apic) && atomic_read(&ktimer->pending)) - return false; - if (!ktimer->tscdeadline) return false; @@ -1735,8 +1732,13 @@ static void start_sw_timer(struct kvm_lapic *apic) static void restart_apic_timer(struct kvm_lapic *apic) { preempt_disable(); + + if (!apic_lvtt_period(apic) && atomic_read(&apic->lapic_timer.pending)) + goto out; + if (!start_hv_timer(apic)) start_sw_timer(apic); +out: preempt_enable(); } |