diff options
| author | Radim Krčmář | 2016-03-02 22:56:44 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2016-03-04 09:29:58 +0100 |
| commit | b39c90b6560c4458d46cb243abea0dcb7bc126d1 (patch) | |
| tree | 0504d13b96b7006735826f3fbbfbb5ac21bd4dc0 /arch/x86/kvm/x86.c | |
| parent | KVM: i8254: pass struct kvm_pit instead of kvm in PIT (diff) | |
| download | kernel-qcow2-linux-b39c90b6560c4458d46cb243abea0dcb7bc126d1.tar.gz kernel-qcow2-linux-b39c90b6560c4458d46cb243abea0dcb7bc126d1.tar.xz kernel-qcow2-linux-b39c90b6560c4458d46cb243abea0dcb7bc126d1.zip | |
KVM: i8254: remove unnecessary uses of PIT state lock
- kvm_create_pit had to lock only because it exposed kvm->arch.vpit very
early, but initialization doesn't use kvm->arch.vpit since the last
patch, so we can drop locking.
- kvm_free_pit is only run after there are no users of KVM and therefore
is the sole actor.
- Locking in kvm_vm_ioctl_reinject doesn't do anything, because reinject
is only protected at that place.
- kvm_pit_reset isn't used anywhere and its locking can be dropped if we
hide it.
Removing useless locking allows to see what actually is being protected
by PIT state lock (values accessible from the guest).
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86/kvm/x86.c')
| -rw-r--r-- | arch/x86/kvm/x86.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a88e1a3eeb69..ce4e91db5bae 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3661,9 +3661,9 @@ static int kvm_vm_ioctl_reinject(struct kvm *kvm, { if (!kvm->arch.vpit) return -ENXIO; - mutex_lock(&kvm->arch.vpit->pit_state.lock); + kvm->arch.vpit->pit_state.reinject = control->pit_reinject; - mutex_unlock(&kvm->arch.vpit->pit_state.lock); + return 0; } |