diff options
| author | Andi Kleen | 2006-04-11 12:54:48 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2006-04-11 15:38:57 +0200 |
| commit | ecc16ba96fd5b1a1c1988f0a2b05ff954bdff728 (patch) | |
| tree | 57a994d0741ddef2c869db0ef83d3456cc6a13df /arch/x86_64/pci/mmconfig.c | |
| parent | [PATCH] i386: Remove bogus special case code from AMD core parsing (diff) | |
| download | kernel-qcow2-linux-ecc16ba96fd5b1a1c1988f0a2b05ff954bdff728.tar.gz kernel-qcow2-linux-ecc16ba96fd5b1a1c1988f0a2b05ff954bdff728.tar.xz kernel-qcow2-linux-ecc16ba96fd5b1a1c1988f0a2b05ff954bdff728.zip | |
[PATCH] i386/x86-64: Remove checks for value == NULL in PCI config space access
Nobody should pass NULL here. Could in theory make it a BUG,
but the NULL pointer oops will do as well.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/x86_64/pci/mmconfig.c')
| -rw-r--r-- | arch/x86_64/pci/mmconfig.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86_64/pci/mmconfig.c b/arch/x86_64/pci/mmconfig.c index b493ed977e7c..1a59a31bb740 100644 --- a/arch/x86_64/pci/mmconfig.c +++ b/arch/x86_64/pci/mmconfig.c @@ -75,7 +75,7 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus, char __iomem *addr; /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ - if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) { + if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) { *value = -1; return -EINVAL; } |