diff options
| author | Eric Dumazet | 2018-11-25 17:26:23 +0100 |
|---|---|---|
| committer | David S. Miller | 2018-11-25 19:36:19 +0100 |
| commit | 4bffc669d6248d655aeb985a0e51bfaaf21c8b40 (patch) | |
| tree | 4e60ee772adb097ec25619769dcf4e02d8829fcb /block/bfq-iosched.c | |
| parent | net: bridge: remove redundant checks for null p->dev and p->br (diff) | |
| download | kernel-qcow2-linux-4bffc669d6248d655aeb985a0e51bfaaf21c8b40.tar.gz kernel-qcow2-linux-4bffc669d6248d655aeb985a0e51bfaaf21c8b40.tar.xz kernel-qcow2-linux-4bffc669d6248d655aeb985a0e51bfaaf21c8b40.zip | |
net: remove unsafe skb_insert()
I do not see how one can effectively use skb_insert() without holding
some kind of lock. Otherwise other cpus could have changed the list
right before we have a chance of acquiring list->lock.
Only existing user is in drivers/infiniband/hw/nes/nes_mgt.c and this
one probably meant to use __skb_insert() since it appears nesqp->pau_list
is protected by nesqp->pau_lock. This looks like nesqp->pau_lock
could be removed, since nesqp->pau_list.lock could be used instead.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Faisal Latif <faisal.latif@intel.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma <linux-rdma@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'block/bfq-iosched.c')
0 files changed, 0 insertions, 0 deletions