diff options
author | Steven Rostedt (VMware) | 2018-11-20 18:40:25 +0100 |
---|---|---|
committer | Steven Rostedt (VMware) | 2018-11-28 02:31:54 +0100 |
commit | 7c6ea35ef50810aa12ab26f21cb858d980881576 (patch) | |
tree | 9fc799fd26232ec5a9018d33d965bb048947aab8 /certs/system_keyring.c | |
parent | function_graph: Move return callback before update of curr_ret_stack (diff) | |
download | kernel-qcow2-linux-7c6ea35ef50810aa12ab26f21cb858d980881576.tar.gz kernel-qcow2-linux-7c6ea35ef50810aa12ab26f21cb858d980881576.tar.xz kernel-qcow2-linux-7c6ea35ef50810aa12ab26f21cb858d980881576.zip |
function_graph: Reverse the order of pushing the ret_stack and the callback
The function graph profiler uses the ret_stack to store the "subtime" and
reuse it by nested functions and also on the return. But the current logic
has the profiler callback called before the ret_stack is updated, and it is
just modifying the ret_stack that will later be allocated (it's just lucky
that the "subtime" is not touched when it is allocated).
This could also cause a crash if we are at the end of the ret_stack when
this happens.
By reversing the order of the allocating the ret_stack and then calling the
callbacks attached to a function being traced, the ret_stack entry is no
longer used before it is allocated.
Cc: stable@kernel.org
Fixes: 03274a3ffb449 ("tracing/fgraph: Adjust fgraph depth before calling trace return callback")
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'certs/system_keyring.c')
0 files changed, 0 insertions, 0 deletions