diff options
| author | Oleg Nesterov | 2013-09-11 23:24:42 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2013-09-12 00:59:05 +0200 |
| commit | 92eaa565add62d56b90987f58ea9feafc5a7c183 (patch) | |
| tree | 78f7bfaa0b99b2b2f5b554bc883b67ac68412e21 /crypto/blowfish_generic.c | |
| parent | exec: move allow_write_access/fput to exec_binprm() (diff) | |
| download | kernel-qcow2-linux-92eaa565add62d56b90987f58ea9feafc5a7c183.tar.gz kernel-qcow2-linux-92eaa565add62d56b90987f58ea9feafc5a7c183.tar.xz kernel-qcow2-linux-92eaa565add62d56b90987f58ea9feafc5a7c183.zip | |
exec: kill ->load_binary != NULL check in search_binary_handler()
search_binary_handler() checks ->load_binary != NULL for no reason, this
method should be always defined. Turn this check into WARN_ON() and move
it into __register_binfmt().
Also, kill the function pointer. The current code looks confusing, as if
->load_binary can go away after read_unlock(&binfmt_lock). But we rely on
module_get(fmt->module), this fmt can't be changed or unregistered,
otherwise this code is buggy anyway.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Zach Levis <zml@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'crypto/blowfish_generic.c')
0 files changed, 0 insertions, 0 deletions